Re: [PATCH 1/4] refs: add referent parameter to refs_resolve_ref_unsafe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> "Kristoffer Haugsbakk" <code@xxxxxxxxxxxxxxx> writes:
>
>>> ...
>>> https://github.com/gitgitgadget/git/pull/1694#issue-2187804953, it
>>> carried over the email addresses as Markdown-formatted hyperlinks.
>>> Currently it reads
>>>
>>>    Cc: Christian Couder [chriscool@xxxxxxxxxxxxx](mailto:chriscool@xxxxxxxxxxxxx)
>>>...
>>>    cc: "Kristoffer Haugsbakk" <code@xxxxxxxxxxxxxxx>
>>>
>>> when I click on "edit", where the last line must be from your manual
>>> fix which GGG picked up. I've cleaned up the PR description manually
>>> now, and for this message I'm also attempting to clean up those square
>>> brackets.
>>
>> When I read that I assumed that Aryan had made the same mistake.
>
> Ah, I see.
>
> I wonder if there are things we can do to help reduce the pain in
> future users of GGG here.
>
>  [...]
>
>  - Or the welcome message GGG adds to the pull-request that begins
>    with "Thanks for taking the time to contribute" can mention
>    something about this?

I've created https://github.com/gitgitgadget/gitgitgadget/pull/1644 to
address this for now.
>
>  - Or possibly the handling of Cc: addresses done by GGG can be
>    tweaked not to cause this?

I wanted to do this first but was deterred by my lack of familiarity
with TypeScript.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux