I'm in a remote cabin with spotty internet this week, and I noticed several delays while running "make test". The culprit was DNS request packets being dropped due to a passing rainstorm, but not enough that the OS decided the network was down (the DNS resolver was on the other end of a VPN). So I was waiting for DNS timeouts. This is kind of an exotic situation, but it seems to me that the test suite should avoid making network requests in general, just for the sake of reproducibility. And avoiding timeouts is a nice bonus. So here are a few small fixes, after which running "make test" requires zero DNS lookups (and presumably zero external network at all, though of course we hit localhost/127.0.0.1 for various http, etc, tests). [1/3]: t5553: use local url for invalid fetch [2/3]: t5551: do not confirm that bogus url cannot be used [3/3]: t/lib-bundle-uri: use local fake bundle URLs t/lib-bundle-uri-protocol.sh | 4 ++-- t/t5551-http-fetch-smart.sh | 1 - t/t5553-set-upstream.sh | 8 ++++---- 3 files changed, 6 insertions(+), 7 deletions(-) -Peff
