Hello Junio! Thanks for the clue, You're right... I only work with the email format so I didn't think of that. My solution doesn't work then... I had a different idea first: to check if we already got an oid and only read a new one once the current diff is finished (and wasn't empty so far). The other one seemed just simpler. I will try again... Thanks & all the best, rob On Fri, Jun 21, 2024 at 7:05 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Rob Linden <rlinden@xxxxxxxxxx> writes: > > > This patch (also attached) fixes it by only considering commit hashes > > in a "From xxxxx..." line: > > If I am not mistaken, "git patch-id" was designed to read from > > git rev-list ... commit range ... | git diff-tree --stdin -p > > where we see > > 9005149a4a77e2d3409c6127bf4fd1a0893c3495 > diff --git a/path b/path > index ... > ... patch text here ... > > so I would suspect that limiting the commit object names only to > those that follow "From " (i.e. the format-patch output or output > with the "--format=email" option) would break existing use cases big > time. >
