On Tue, Jun 18, 2024 at 04:38:07AM -0400, Karthik Nayak wrote: > shejialuo <shejialuo@xxxxxxxxx> writes: > > [snip] > > > struct fsck_options { > > + /* > > + * Reorder the fields to allow `fsck_ref_options` to use > > + * the interfaces using `struct fsck_options`. > > + */ > > Why is this added? It makes sense to have it in the commit message > because it talks about the change, but why make it persistent in the > code? > I explicitly add this comments due to the following reasons: 1. If someone needs to change the `fsck_options`, without this comment, he might be just add some new fields at top. Although the change will fail the tests here, I think we should mention this in code. 2. My later intention is that we should extract these common fields out of the `fsck_options` and `fsck_ref_options`. > [snip]