Re: [PATCH] worktree_git_path(): move the declaration to path.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> On Sat, Jun 8, 2024 at 6:39 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>
>> The definition of this function is in path.c but its declaration is
>> in worktree.h, which is something unexpected.  The function is
>> explained as "Similar to git_path()"; declaring it next to where
>> git_path() is declared would make more sense.
>>
>> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>> ---
>>  path.h     | 9 +++++++++
>>  revision.c | 1 +
>>  worktree.h | 8 --------
>>  3 files changed, 10 insertions(+), 8 deletions(-)
>
> Simple and straightforward, and the rationale makes sense to me.

Thanks.  It helped that there was only one customer that needed
adjustment.  Will merge to 'next'.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux