On Tue, Jun 11, 2024 at 06:27:51PM +0530, Ghanshyam Thakkar wrote: > On Tue, 11 Jun 2024, Patrick Steinhardt <ps@xxxxxx> wrote: > > The "oidtree" test helper sets up a Git repository, but this is really > > only used such that `get_oid_hex()` can parse both SHA1 and SHA256 > > object hashes. The `struct oidtree` interface itself does not care at > > all about the object hash of `the_repository`, and always asserts that > > inserted object IDs have their hash algorithm set. > > > > Stop initializing the repository and instead use `get_oid_hex_any()` to > > parse object IDs for the "contains" action, like we already do when > > parsing the "insert" action. > > I think the motive of this patch is already achieved in > 'gt/unit-test-oidtree'[1], if this is to be merged after that. > > Thanks. > > [1]: https://github.com/git/git/commit/79d9e08db3a08c5a06e2633a39cd38b980e654f4 > mailing list: https://lore.kernel.org/git/20240608165731.29467-1-shyamthakkar001@xxxxxxxxx/ Okay. I'll make sure to evict this patch once your patch series gets merged down to "next". Thanks for the hint. Patrick
Attachment:
signature.asc
Description: PGP signature
