On 2024-06-10 21:14, Rubén Justo wrote:
On Mon, Jun 10, 2024 at 03:09:48PM +0100, Phillip Wood wrote:
I'm still not really convinced that the escape sequences are a
problem.
A concern about the escape sequences was mentioned in this message:
https://lore.kernel.org/git/b7e24b08-40a1-4b18-89f6-e25ab96facaf@xxxxxxxxx/
It arose when exploring the possibility of using the new command "|"
with tools that do not support escape sequences, e.g.: "| vim -", or
"| clip.exe" to send the hunk to the clipboard, on Windows.
Hmm, I asked [1] why do we need "|xyz" and escape-sequence-free hunks,
and the answer is above. Another example would be "|xclip" on Linux.
With that in mind, let's have "P" and "Pxyz" that both honor
"color.diff",
as already proposed, [1] and "|xyz" that strips the coloring escape
sequences.
[1]
https://lore.kernel.org/git/3268c498c9ee60803384db6db2d0e94b@xxxxxxxxxxx/