René Scharfe <l.s.r@xxxxxx> writes:
> +check_external_diff () {
> + expect_code=$1
> + expect_out=$2
> + expect_err=$3
> + command_code=$4
> + shift 4
> + options="$@"
Tiny nit, but I'd prefer to see "$@" reserved for its magic and all
other times where it is equivalent to "$*", see the latter used.
Other than that, all three patches looked good to me. Thanks.
