Junio C Hamano <gitster@xxxxxxxxx> writes: >> +/* timestamp of 2099-12-31T23:59:59Z, including 32 leap days */ >> +static const time_t timestamp_max = ((2100L - 1970) * 365 + 32) * 24 * 60 * 60 - 1; > > I wonder if this should be of timestamp_t type instead, as the check > is done against *timestamp in parse_date_basic() where *timestamp is > of type timestamp_t to match? The CI build on Windows tells me that my worry was warranted. https://github.com/git/git/actions/runs/9424299208/job/25964281907#step:4:643 (GitHub seems to show the breakage details only to those who are logged in, so you'd need to be logged in to visit that link) Error: date.c:873:75: integer overflow in expression of type 'long int' results in '-192522496' [-Werror=overflow] 873 | static const time_t timestamp_max = ((2100L - 1970) * 365 + 32) * 24 * 60 * 60 - 1; | ^ Error: date.c:873:1: overflow in constant expression [-Werror=overflow]
