"Philip Peterson via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Philip Peterson <philip.c.peterson@xxxxxxxxx>
>
> Also rename parse_range to parse_fragment_range for external linkage.
>
> Signed-off-by: Philip Peterson <philip.c.peterson@xxxxxxxxx>
> ---
This version saw no reviews (unfortunately).
I just gave another quick glance, did not spot anything glaringly
wrong, and the way the tests are organized as a series of ...
> + TEST(setup_static((struct test_case) {
> + .line = "@@ -4,4",
> + .offset = -1,
> + .expect_suffix = " +",
> + .expect_result = FAILURE,
> + .expect_p1 = 9999,
> + .expect_p2 = 9999
> + }), "negative offset");
... rather pleasant to read. I'd admit that it does not count as a
proper review, though.
Thanks.
