Re: [GSoC][PATCH 1/6] reftable: clean up reftable/pq.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 6, 2024 at 12:07 PM Chandra Pratap
<chandrapratap3519@xxxxxxxxx> wrote:
>
> On Thu, 6 Jun 2024 at 14:21, Christian Couder
> <christian.couder@xxxxxxxxx> wrote:
> >
> > On Thu, Jun 6, 2024 at 9:57 AM Chandra Pratap
> > <chandrapratap3519@xxxxxxxxx> wrote:
> > >
> > > According to Documentation/CodingGuidelines, control-flow statements
> > > with a single line as their body must omit curly braces. Make
> > > reftable/pq.c conform to this guideline. Besides that, remove
> > > unnecessary newlines and variable assignment.
> >
> > A commit subject like "reftable/pq: remove unnecessary curly braces"
> > might be a bit more specific.
>
> There are other forms of cleanup also being performed, like removing
> unnecessary newlines and variable assignment. Would it still be okay
> to sweep it all under 'removing unnecessary braces'?

I think the removal of unnecessary braces is the main change and other
changes are made while at it, so I think it's Ok.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux