On Wed, Jun 05, 2024 at 06:46:46AM -0400, Jeff King wrote: > On Fri, May 31, 2024 at 08:27:13AM -0700, Junio C Hamano wrote: > > > I wonder if we can do something to separate these two concerns > > apart, using a trick similar to what we often use with an extra > > variable "to_free". Doing so would bloat the refspec_item, but > > unlike the references themselves, there won't be thousands of them, > > so it may not be an issue, perhaps? > > I had a similar thought while looking at this spot a while ago, so I dug > this attempt out of my stash. It's quite ugly, as you need to keep the > storage pointer and the const pointer in sync. Especially because > there's a lot of clever pointer indirection via match_name_with_pattern(). > > So I don't think it's the best way to refactor this code, but I present > it here for your amusement/disgust. This is on top of what you have > queued in ps/no-writable-strings. Just for the record: I'll keep such a refactoring out of this patch series as it is already big enough. I do agree though that we should ideally fix this interface in a subsequent iteration. Patrick
Attachment:
signature.asc
Description: PGP signature
