On Wed, Jun 05, 2024 at 08:39:59AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > IMHO we should consider getting rid of it entirely. I think the only > > thing that uses it is t4153 (AFAICT it is luckily not racy because it > > does not actually read stdin, but only checks isatty). > > Sounds like a better approach than piling another workaround on the > test helper. Reading the old discussion, we seem to have been in > agreement that we generally do not have to insist reading from a tty > and certainly the "add -p" codepath is not one of those "if your > other payload must come from the standard input, your instructions > to specify how to handle that data needs to come from elsewhere, and > that is /dev/tty" cases. I think we got rid of all of the "read interactive input over tty" cases. The one that I still see is am's heuristic to use isatty() to decide whether the user might send patches over stdin. I just sent a separate patch series which I think improves the situation. And then either Rubén could build on top of that (if we think it will graduate quickly) or he could do his optional patch, and we could rip it back out when the two are merged. -Peff
