On Tue, Jun 4, 2024 at 8:19 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> * gt/decorate-unit-test (2024-05-28) 1 commit
> - t/: migrate helper/test-example-decorate to the unit testing framework
>
> A test helper that essentially is unit tests on the "decorate"
> logic has been rewritten using the unit-tests framework.
>
> Will merge to 'next'?
> source: <20240528125837.31090-1-shyamthakkar001@xxxxxxxxx>
The only nit found in this was about how tests were split. Josh
Steadmon recently said that the split is reasonable as it makes things
similar to the original code, and I agree with that. So I think it
should be good to go.
> * gt/t-hash-unit-test (2024-05-29) 2 commits
> - t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash
> - strbuf: introduce strbuf_addstrings() to repeatedly add a string
>
> A pair of test helpers that essentially are unit tests on hash
> algorithms have been rewritten using the unit-tests framework.
>
> Will merge to 'next'?
> source: <20240529080030.64410-1-shyamthakkar001@xxxxxxxxx>
I agree with Patrick that the v5 properly addresses the small nits
Patrick found in the v4, and the v5 LGTM.
