Patrick Steinhardt <ps@xxxxxx> writes: > @@ reftable/readwrite_test.c: static void test_write_key_order(void) > + struct strbuf buf = STRBUF_INIT; > + struct reftable_writer *w = > reftable_new_writer(&strbuf_add_void, &noop_flush, &buf, &opts); > ++ char a[] = "a", b[] = "b", target[] = "target"; So you decided to go in the complete opposite direction, hmph... I was hoping that we do not add more "writable" pieces of memory like target[] only to please the constness-strict compilers.