Re: [PATCH 2/2] format-patch: move range/inter diff at the end of a single patch output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-05-29 16:29, Junio C Hamano wrote:
Patrick Steinhardt <ps@xxxxxx> writes:

On Tue, May 28, 2024 at 09:50:43AM -0700, Junio C Hamano wrote:
Patrick Steinhardt <ps@xxxxxx> writes:

> Yeah, that's definitely better. Whether it's preferable over having it
> after the signature separator I don't know. I personally liked that
> version better, but can totally see why others may not like it.

I do not think anybody posted a version that writes inter/range diff
ater the signature mark.

No, I'm talking about the version that you hand crafted initially and
that kicked off this topic.

Ah, https://lore.kernel.org/git/xmqqh6ep1pwz.fsf_-_@gitster.g/ I
forgot all about it already ;-).

... I just don't have a strong preference between the old and
new formats by now. If you or others feel strongly I don't mind at all
if this patch lands.

Let's scrap it then.  I do not think a single-patch topic happens
all that often anyway.

Hmm. Actually, I find it logical and I don't think it should be scrapped.
As I wrote already, I find range diffs as really long footnotes, and
placing them at the end of "documents" seems like a logical choice to me.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux