On Wed, May 29, 2024 at 01:21:47PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@xxxxxx> writes:
>
> > } else if (skip_prefix(buf.buf, "option ", &arg)) {
> > + const char *value = strchr(arg, ' ');
> > + size_t arglen;
> > int result;
> >
> > + if (value) {
> > + arglen = value - arg;
> > + value++;
> > + } else {
> > + arglen = strlen(arg);
> > value = "true";
> > + }
>
> There is a micro optimization opportunity here.
>
> const char *value = strchrnul(arg, ' ');
> size_t arglen = value - arg;
>
> if (*value)
> value++; /* skip over SP */
> else
> value = "true";
>
> But other than that, very cleanly done.
Indeed, that version looks nicer. Thanks!
Patrick
Attachment:
signature.asc
Description: PGP signature
