At 2024-05-28 20:05:48, "Patrick Steinhardt" <ps@xxxxxx> wrote: [snip] >> >> +test_expect_success 'clone bundle with fetch.fsckObjects' ' >> + test_create_repo bundle-fsck && >> + ( >> + cd bundle-fsck && >> + test_commit first && >> + cat >data <<-EOF && >> + tree $(git rev-parse HEAD^{tree}) >> + parent $(git rev-parse HEAD) >> + author A U Thor >> + committer A U Thor >> + >> + commit: this is a commit with bad emails >> + >> + EOF >> + git hash-object --literally -t commit -w --stdin <data >commit && >> + git branch bad $(cat commit) && >> + git bundle create bad.bundle bad >> + ) && >> + test_must_fail git -c fetch.fsckObjects=true \ >> + clone bundle-fsck/bad.bundle bundle-fsck-clone 2>err && >> + test_grep "missingEmail" err >> +' > >Do we also want to have a test for `transfer.fsckObjects`? Sure, some more combinations of "fetch.fsckObjects" and "transfer.fsckObjects" are added in tests. Xing Xin