On Thu, May 30, 2024 at 09:04:28AM +0200, Patrick Steinhardt wrote: > > But if the actual move queues any errors in only_match_skip_worktree, > > that can cause us to jump straight to the "out" label to clean up, > > skipping the free() and leaking the array. > > > > Let's push the free() down past the "out" label so that we always clean > > up (the array is initialized to NULL, so this is always safe). We'll > > hold on to the memory a little longer than necessary, but clarity is > > more important than micro-optimizing here. > [...] > > Ouf of curiosity, did you check whether this makes any additional tests > pass with SANITIZE=leak? No, I didn't. I think you can only trigger it with a sparse index, at which point it seemed like diminishing returns to try to reproduce. But running in "check" mode is not too hard... ...time passes... Looks like no. The obvious candidate would be t7002-mv-sparse-checkout, but it looks like the sparse-checkout code has minor leaks itself. -Peff
