Re: safe.directory wildcards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 29.05.24 um 18:02 schrieb Junio C Hamano:
Stefan Metzmacher <metze@xxxxxxxxx> writes:

given the recent importance of safe.directory, it would be great to
have something like '/data/git/*' to be supported, not just a single '*'
for a server that serves a lot of public git repositories owned by different owners.

Interesting.

The original commit that introduced the '*' opt-out, 0f85c4a3
(setup: opt-out of check with safe.directory=*, 2022-04-13), was
done to specifically help those who have a large list of shared
repositories.  We could have moved all the way to allow globs back
then, and the possibility certainly was brought up.

   https://lore.kernel.org/git/xmqqk0bt9bsb.fsf@gitster.g/

But the loosening was done in a context of "brown paper bag fix"
so it is very much understandable that we did the simplest and most
obvious thing to avoid making silly mistakes in a haste.

I am reluctant to use wildmatch() but I would expect that in
practice "leading path matches" (in other words, "everything under
this directory is OK") is sufficient, perhaps?

That's exactly what I tried first and then looked
at the sources to check why it doesn't help :-)

I guess it will be useful to have.

Thanks!
metze




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux