Hi, On Tue, 6 Nov 2007, Jeff King wrote: > On Tue, Nov 06, 2007 at 11:01:03AM +0000, Johannes Schindelin wrote: > > > > > So? Why *STOP* reading the mails if just one of the directories could > > > > not be opened? IOW, I suggest: > > > > > > Because you are then trying to apply a patch series with some patches > > > potentially missing? Continuing only on errno == ENOENT seems prudent. > > > > I fail to see how the absence of one of cur/ or new/ can lead to the > > absence of patches. You could forget to save some patches, yes, but the > > presence of cur/ and new/ is no indicator for that. > > Read my message again. Alex is proposing ignoring errors in opening the > directories; I am proposing ignoring such errors _only_ when the error > is that the directory does not exist. > > IOW, if there is some other error in opening the directory, it should be > fatal, because you might be missing patches. Yeah, sorry, I missed that. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
