Dragan Simic <dsimic@xxxxxxxxxxx> writes:
> Hello Junio,
>
> Please see my comments below.
>
> On 2024-05-22 01:20, Junio C Hamano wrote:
>> In an "git add -p" session, especially when we are not using the
>
> s/In an/In a/
Good eyes.
>
>> single-char mode, we may see 'qa' as a response to a prompt
>
> Perhaps s/single-char/single-character/
I shouldn't have been loose in the language. Rather, we should say
"single key mode", as the knob to control the feature is the
"interactive.singlekey" variable.
>> + /* 'g' takes a hunk number, '/' takes a regexp */
>> + if (1 < s->answer.len && (ch != 'g' && ch != '/')) {
>
> To me, "s->answer.len > 1" would be much more readable, and
> I was surprised a bit to see the flipped variant. This made
> me curious; would you, please, let me know why do you prefer
> this form?
"textual order should reflect actual order" (read CodingGuidelines).
For more backstory,
https://lore.kernel.org/git/?q=%22textual+order%22+%22actual+order%22
Thanks.
