On Tue, May 21, 2024 at 07:44:23AM +0200, Patrick Steinhardt wrote: > On Fri, May 17, 2024 at 09:01:49PM +0200, Marcel Telka wrote: > > This makes the grep usage fully POSIX compliant. The ability to > > Nit: we typically don't say "This commit", of which "This" is another > version. Instead, we use imperative style as if instructing the code to > change. Also, we typically first explain what the problem is before we > say how we fix it. > > I don't think this is worth a reroll though, it's only a hint for the > next patch you may be sending :) > > > enable ERE features in BRE using backslash is a GNU extension. > > > > Signed-off-by: Marcel Telka <marcel@xxxxxxxx> > > It would have been nice if this thread was connected to the thread of > your first version so that it's easier to follow the discussion, e.g. by > using `--in-reply-to=` in git-send-email(1) or git-format-patch(1). Thank you for hints. Really appreciated. This was my first attempt to use the `git send-email` workflow so it is not surprising I missed the --in-reply-to= option :-). Best regards. -- +-------------------------------------------+ | Marcel Telka e-mail: marcel@xxxxxxxx | | homepage: http://telka.sk/ | +-------------------------------------------+
