On Fri, May 17, 2024 at 10:14:19AM +0200, Karthik Nayak wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Hi, > > > > this is the third version of my patch series that exposes several write > > options of the reftable library via Git configs. > > > > Changes compared to v2: > > > > - Adapted patch 2 such that we now pass options as const pointers > > instead of by value. > > > > - Removed a confusing sentence in the documentation of the restart > > points in patch 8. > > > > Other than that I decided to rebase this on top of the current "master" > > branch at 0f3415f1f8 (The second batch, 2024-05-08). This is because the > > revamped patch 2 would cause new conflicts with 485c63cf5c (reftable: > > remove name checks, 2024-04-08) that didn't exist in v2 of this patch > > series yet. Rebasing thus seemed like the more reasonable option. > > > > I did go through the patches and only had a small nit, but not worth a > re-roll. Thanks! > I was also wondering what happens if users tweak these values when a > repository already contains reftables with different values. Seems like > it'll use the new configuration during new table creation and also > during autocompaction. Which makes sense. Yup. It should be fine to change the values at will and for different tables to be written with different configs. Patrick
Attachment:
signature.asc
Description: PGP signature
