Patrick Steinhardt <ps@xxxxxx> writes: > On Tue, May 14, 2024 at 08:08:19AM -0700, Junio C Hamano wrote: >> Patrick Steinhardt <ps@xxxxxx> writes: >> >> > Is there a specific reason why this needs a whole patch suite, as >> > opposed to adding the tests to the respective test suites of the >> > commands? >> >> Yes, testing out-of-repository operations needs certain trick and >> people forget to write such tests using the GIT_CEILING_DIRECTORIES >> mechanism. Having one place where we have an enumeration of >> commands that are designed to be usable outside repository is a >> handy way to make sure that we have enough test coverage. It would >> make it easy to control how GIT_DEFAULT_HASH environment is set >> during these tests to have them in all one place. > > We already have the "nogit" command that neatly encapsulates all of this > logic, so the trickery is contained in a single spot in practice. Heh, you asked for "a" specific reason, and I listed three. The tests that are spread across many scripts make it harder to see if we have enough coverage for the out-of-repository operations, and the use of "nongit" helper does not change the equation, does it?
