* Jeff King (peff@xxxxxxxx) wrote:
> On Sun, May 12, 2024 at 01:59:13AM +0100, Dr. David Alan Gilbert wrote:
>
> > 'loose_object_iter' in fetch-pack.c is unused since
> > commit 97b2fa08b6b9ee3e ("fetch-pack: drop custom loose object cache")
> > Remove it.
>
> Thanks, this was my fault for leaving it in. The patch looks obviously
> good.
Thanks.
Most projects I've looked at seem to have one or more.
> I wish there was a good way to get the compiler to report on unused
> types, but I don't think there is (it's a complicated problem in
> general, but file-local ones like this feel like they should be easy to
> spot).
Alas not.
> Here's a really hacky (and quadratic) attempt to find defined structs
> that aren't mentioned elsewhere:
>
> for i in $(git grep -ho '^struct [a-z_]* {' | cut -d' ' -f2)
> do
> used=$(git grep -Phc "\b$i\b" |
> perl -ne '$x += $_; END { print $x }')
> echo "$used $i"
> done |
> sort -n
>
> which finds exactly one unused struct, the one in this patch.
My similarly hacky script was:
grep -r '^struct [^(=]* {'| tr ':' ' ' |
while read FNAME STRUCT NAME TAIL
do
echo "$FNAME" | grep -q '[.]c$' || continue
echo ">>>" $FNAME ' : ' $NAME
echo -n "Count: "
grep $NAME $FNAME | wc -l
#grep $VARNAME $FNAME
done
(A count of 1 being the unused ones).
Dave
>
> -Peff
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
