On Sat, 11 May 2024 at 06:13, Jeff King <peff@xxxxxxxx> wrote:
>
> On Fri, May 10, 2024 at 03:52:25PM +0800, ryenus wrote:
>
> > Command I run: `parallel git -C {} fetch ::: repo1 repo2 rep3`, which is
> > to fetch multiple repositories in parallel using GNU parallel.
> >
> > This worked pretty well for me in the past, however with git version
> > 2.45, maybe 2.44 as well, it would randomly emit below error:
> >
> > > failed to store: -25299
>
> There's some related discussion over in:
>
> https://lore.kernel.org/git/pull.1729.git.1715328467099.gitgitgadget@xxxxxxxxx/
>
> But most curious to me is:
>
> > But if I do this without GNU parallel, or `parallel -j1` with only
> > one worker, things work just fine.
> > And when I switched back to git 2.43.2, I don't see such error either.
>
> I would have assumed this was an issue going back to 2011, since each of
> those fetches is going to try storing the successful credential. But if
> older-but-recent versions of Git did not have the problem, it could be
> that we are being more aggressive about invoking storage for some
> reason. Can you bisect?
>
> The obvious recent changes to the credential code were brian's
> capability/state series, but those are not yet in a released version
> (and from a quick scan I did not see anything that would obviously
> change things there).
>
> -Peff
@Bo98, possible to share any insight? It appears related to the following patch:
* osxkeychain: replace deprecated SecKeychain API [1]
[1]: https://github.com/git/git/commit/9abe31f5f161be4d69118bdfae00103cd6efa510
Apologize if I'm guessing it wrong :-)
