On Thu, May 09, 2024 at 06:04:59PM -0700, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > * cw/git-std-lib (2024-02-28) 4 commits > > - SQUASH??? get rid of apparent debugging crufts > > - test-stdlib: show that git-std-lib is independent > > - git-std-lib: introduce Git Standard Library > > - pager: include stdint.h because uintmax_t is used > > > > Split libgit.a out to a separate git-std-lib tor easier reuse. > > > > Expecting a reroll. > > source: <cover.1696021277.git.jonathantanmy@xxxxxxxxxx> > > Just a heads-up. The topic is pushed out of 'seen', as it seems to > be hated by osx-* jobs when linking programs. As the topic has been > expecting a reroll for some time, it is not ultra urgent to fix > this, but before resurrecting it, we may want to look into it. > > https://github.com/git/git/actions/runs/9023837489 > > is an example run where we see error messages like: > > ld: warning: ignoring duplicate libraries: 'git-std-lib.a', 'libgit.a', 'reftable/libreftable.a', 'xdiff/lib.a' > > and > > ld: Undefined symbols: > _git_config_get_bool, referenced from: > _precompose_string_if_needed in git-std-lib.a[11](precompose_utf8.o) > > in both clang and gcc jobs. > > We did not see these breakages before, and we do not see these > breakages in today's 'seen' with this topic excluded. I haven't > tried to include this but excluding tb/precompose-getcwd topic > instead, which I suspect might also work. I think that including tb/precompose-getcwd should be fine. As a side note: Thanks for cleaning that up. I tried to reproduce the breakage, but could not. The github log says: 2024-05-09T21:33:21.8856440Z ++ CI_COMMIT=0c244ffcb1ec0d507d71e244817a3d1972acde59 (But that commit is probably gone). Trying to compile commit 0ebed321d488910d7b34953df0e3bc9d5d74ba70 (HEAD, junio/cw/git-std-lib) Author: Junio C Hamano <gitster@xxxxxxxxx> Date: Wed Feb 28 12:42:51 2024 -0800 SQUASH??? get rid of apparent debugging crufts Did not bring up the problems here, compiling worked. The problem on the github run is that LINK t/unit-tests/bin/t-ctype failed because of missing symbols which should be provided by compat/precompose_utf8.c I am not an expert on the libification effort. Someone could wildly speculate that this very version of "seen" did have merge conflicts, that led to compat/precompose_utf8.o missing somewhere in the Makefile(s)
