Re: [PATCH 2/4] http: add the ability to log progress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 08, 2024 at 02:44:51PM +0200, Toon Claes wrote:

> @@ -1457,6 +1458,9 @@ struct active_request_slot *get_active_slot(void)
>  	curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1);
>  	curl_easy_setopt(slot->curl, CURLOPT_FAILONERROR, 1);
>  	curl_easy_setopt(slot->curl, CURLOPT_RANGE, NULL);
> +	curl_easy_setopt(slot->curl, CURLOPT_NOPROGRESS, 1L);
> +	curl_easy_setopt(slot->curl, CURLOPT_XFERINFODATA, NULL);
> +	curl_easy_setopt(slot->curl, CURLOPT_XFERINFOFUNCTION, NULL);

These last two CURLOPTs appeared in 7.32.0, but our INSTALL doc claims
to support back to 7.21.3. Before that you're supposed to use
PROGRESSFUNCTION instead, which has a slightly different signature. I
think you could support both, though it would also be OK to just disable
this extra progress for antique curl.

It might also be reasonable to just bump to 7.32.0 as our minimum. The
last bump was recent via c28ee09503 (INSTALL: bump libcurl version to
7.21.3, 2024-04-02), and the version picked there was arbitrary-ish (it
was something we had happened to depend on accidentally). 7.32.0 is
itself almost 11 years old now.

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux