On Thu, May 09, 2024 at 08:24:05AM -0700, Junio C Hamano wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > Of course, we need to make sure precompose_string_if_needed() will > leave the strbuf in an consistent state. I think the implementation > of that helper function in this patch already does so, so > > strbuf_grow(sb, guessed_len); > if (getcwd(sb->buf, sb->alloc)) { > strbuf_setlen(sb, strlen(sb->buf)); > precompse_strbuf_if_needed(sb); > I think that is what I have in mind as well. Thanks for the review, a V2 should come the next days.