Re: [PATCH v4 0/3] advice: add "all" option to disable all hints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

"James Liu" <james@xxxxxxxxxxx> writes:

> On Tue May 7, 2024 at 2:47 AM AEST, Junio C Hamano wrote:
>> I count two messages from Karthik for v4, one of them being "this
>> round looks good", to which you said "thanks".
>>
>> If you mean the other comment about a non-sentence in the proposed
>> log message of [2/3], the copy I have in 'seen' says this:
>>
>>     doc: add spacing around paginate options
>>
>>     Make the documentation page consistent with the usage string printed by
>>     "git help git" and consistent with the description of "[-v | --version]"
>>     option.
>>
>>     Signed-off-by: James Liu <james@xxxxxxxxxxx>
>>     Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>>
>> If that looks good enough to both of you, then we can probably
>> declare victory and mark the topic for 'next'.
>>
>> Thanks.
>
> Yes I'm happy with that. Thanks Junio!
>
> Cheers,
> James

Looks good to me too :)

Thanks
Karthik

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux