Patrick Steinhardt <ps@xxxxxx> writes: > I have just sent out a new version [1] that fixes a few commit messages. > Other than that I think this version should be ready to go. > > [1]: https://lore.kernel.org/git/cover.1714982328.git.ps@xxxxxx/T/#u Thanks. >> * ps/undecided-is-not-necessarily-sha1 (2024-04-30) 13 commits >> . repository: stop setting SHA1 as the default object hash >> . oss-fuzz/commit-graph: set up hash algorithm >> . builtin/shortlog: don't set up revisions without repo >> . builtin/diff: explicitly set hash algo when there is no repo >> . builtin/bundle: abort "verify" early when there is no repository >> . builtin/blame: don't access potentially unitialized `the_hash_algo` >> . builtin/rev-parse: allow shortening to more than 40 hex characters >> . remote-curl: fix parsing of detached SHA256 heads >> . attr: fix BUG() when parsing attrs outside of repo >> . attr: don't recompute default attribute source >> . parse-options-cb: only abbreviate hashes when hash algo is known >> . path: move `validate_headref()` to its only user >> . path: harden validation of HEAD with non-standard hashes >> >> Before discovering the repository details, We used to assume SHA-1 >> as the "default" hash function, which has been corrected. Hopefully >> this will smoke out codepaths that rely on such an unwarranted >> assumptions. >> >> Seems to break t0003 with a NULL the_repository. >> >> Ejected out of 'seen' for now. >> source: <cover.1714371422.git.ps@xxxxxx> > > Interesting, I couldn't reproduce this issue when rebasing the patches > onto "seen". There were merge conflicts though, both with > jc/no-default-attr-tree-in-bare and ps/the-index-is-no-more. So maybe > there was a mismerge involved somewhere? That is very possible.