Jeff King <peff@xxxxxxxx> writes: >> if test -z "${TEST_SHELL_PATH:+set}" >> then >> echo >&2 "ERROR: TEST_SHELL_PATH is not set or empty" >> >> may be what we want here. > > If we are using ":+" to handle the empty string, I think just: > > if test -z "$TEST_SHELL_PATH" > > is sufficient, no? Yes. And the other part of this hunk still needs fixing, namely, > + exit 1 > + fi > + exec ${TEST_SHELL_PATH} "$@" > + ;; the above reference needs to be quoted protect $IFS in the path.