Justin Tobler <jltobler@xxxxxxxxx> writes: > On 24/05/03 08:56AM, Patrick Steinhardt wrote: >> On Thu, May 02, 2024 at 02:38:37PM -0500, Justin Tobler wrote: >> > The `check-whitespace` CI job is only available as a GitHub action. To >> > help enable this job with other CI providers, first separate the logic >> > performing the whitespace check into its own script. In subsequent >> > commits, this script is further generalized allowing its reuse. >> > >> > Helped-by: Patrick Steinhardt <ps@xxxxxx> >> > Signed-off-by: Justin Tobler <jltobler@xxxxxxxxx> >> > --- >> [snip] >> > diff --git a/ci/check-whitespace.sh b/ci/check-whitespace.sh >> > new file mode 100755 >> > index 0000000000..f57d1ff5f0 >> > --- /dev/null >> > +++ b/ci/check-whitespace.sh >> > @@ -0,0 +1,74 @@ >> > +#!/bin/bash >> >> This needs to be either "/bin/sh" or "/usr/bin/env bash". > > Since the script is using some shell specific features, I'll update this > to "/usr/bin/env bash" in the next version. This is a question to Patrick, but what makes it bad to assume "bash" is in "/bin" when it is OK to assume that "env" is always in "/usr/bin"? All other comments by Patrick I found very sensible. Thanks, both of you.
