On 2024.04.24 14:25, Junio C Hamano wrote:
> Josh Steadmon <steadmon@xxxxxxxxxx> writes:
>
> > +case "$1" in
> > +*.sh)
> > + if test -z "${TEST_SHELL_PATH+set}" ; then
> > + echo "ERROR: TEST_SHELL_PATH is not set" >&2
>
> Style.
>
> As an empty string is not a reasonable value for this variable (and
> you do not quote ${TEST_SHELL_PATH} when you use it in "exec" below),
>
> if test -z "${TEST_SHELL_PATH:+set}"
> then
> echo >&2 "ERROR: TEST_SHELL_PATH is not set or empty"
>
> may be what we want here.
>
> > + exit 1
> > + fi
> > + exec ${TEST_SHELL_PATH} "$@"
> > + ;;
> > +*)
> > + exec "$@"
> > + ;;
> > +esac
>
> Other than that, the update in this iteration looks reasonable to
> me.
>
> Thanks.
Fixed in V5, thanks.
