Re: [PATCH v3 2/3] builtin/tag.c: add --trailer arg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 29, 2024 at 06:54:22PM +0000, John Passaro via GitGitGadget wrote:
> From: John Passaro <john.a.passaro@xxxxxxxxx>
> 
> git-tag currently supports interpreting trailers from an annotated tag
> message, using --list --format="%(trailers)". There is no ergonomic way
> to add trailers to an annotated tag message.
> 
> In a previous patch, we refactored git-commit's implementation of its
> --trailer arg to the trailer.h API. Let's use that new function to teach
> git-tag the same --trailer argument, emulating as much of git-commit's
> behavior as much as possible.
> 
> Signed-off-by: John Passaro <john.a.passaro@xxxxxxxxx>
> Helped-by: Patrick Steinhardt <ps@xxxxxx>

Same comment here regarding the order of trailers.

Other than that this commit looks good to me, thanks!

Patrick

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux