On 24/04/30 11:59AM, James Liu wrote: > Thanks for putting this together, Justin! > > > +check-whitespace: > > + image: ubuntu:latest > > I wonder if we should pin to `ubuntu:22.04` and only update this for > each LTS release. It seems like we've done this for the > `static-analysis` job above. I'm not sure if it particually matters. I know Patrick recently submitted the following also using `ubuntu:latest`: https://lore.kernel.org/git/01fb94999f8e2014ba4d09ce7451a4f5d315ee72.1714371146.git.ps@xxxxxx/#r I can change it though if there is strong opinion one way or the other. > > > + before_script: > > + - ./ci/install-docker-dependencies.sh > > + script: > > + - ./ci/check-whitespace.sh $CI_MERGE_REQUEST_TARGET_BRANCH_SHA > > + rules: > > + - if: $CI_PIPELINE_SOURCE == 'merge_request_event' > > diff --git a/ci/check-whitespace.sh b/ci/check-whitespace.sh > > new file mode 100755 > > index 0000000000..1cad2d7374 > > --- /dev/null > > +++ b/ci/check-whitespace.sh > > @@ -0,0 +1,16 @@ > > +#! /bin/sh > > nit: there seems to be extra whitespace after the shebang :D > Whoops... I'll address this in a subsequent version. -Justin
