Hey Phillip, Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > Hi Karthik > > On 29/04/2024 19:57, Karthik Nayak wrote: >> Phillip Wood <phillip.wood123@xxxxxxxxx> writes: >>>> via the uninitialized value when calling `is_null_oid()`, which causes >>>> us to segfault. >>>> >>>> It is somewhat questionable in the first place that we declare a ref to >>>> be a pseudorefe depending on whether it resolves to an object ID or not. >>> >>> If I remember rightly Karthik added that check to avoid the files >>> backend calling a file with a name that matched the pseudoref syntax a >>> pseudoref when it wasn't actually a pseudoref. >> >> Not sure I follow. I think it was strictly done to ensure we don't >> consider symrefs as pseudorefs [1]. > > Junio suggested using refs_read_ref_unsafe() to ensure we don't consider > symrefs as pseudorefs but your patch was already reading the ref to > ensure it was not some random file whose name matches the pseudoref syntax. > > Best Wishes > > Phillip Oh yes. You're absolutely correct. I just didn't understand what you were referring to :)
Attachment:
signature.asc
Description: PGP signature
