On 2024-04-27 20:18, Junio C Hamano wrote:
Junio C Hamano <gitster@xxxxxxxxx> writes:
Well, v1 and v3-v5 saw comments only from me. There was a comment
on v2 by Kristoffer Haugsbakk about phrasing in proposed log
message. v6 had Eric's "Meh, either way".
FWIW, somewhere between v2 and v3 may have been a good place to
stop.
"After calling send_message(), give an extra blank line before the
next message" was extremely easy to see why it was a good idea.
Mixing it with "oh, during the process of a single invocation of
send_message(), there may be other places that want extra blank
lines" made the changes less focused. Personally I lost interest
in the series at around that point.
Thank you for your additional feedback.
Admittedly, the whole endeavor could have been handled better from
my side, with fewer "oh, let's do it differently and a bit better"
iterations that inevitably made the whole thing harder to follow and
become interested with.
However, I find improving the way "git send-mail" works rather
important,
because if it bothers me, it must be bothering other people, who may
simply not be on the mailing list. As we know, a lot of people quite
regularly complain through different channels about sending patches by
email being not user-friendly, which should make any attempts to make
it more user-friendly quite important, if you agree.
I have some more plans for improving "git send-mail" and adding some new
features, but I need to get everything into the final shape I'm pretty
much 100% satisfied with, both from the design and the implementation
standpoints, before sending the patches over.
