On 2024.04.12 00:22, Jeff King wrote: > On Thu, Apr 11, 2024 at 11:14:24AM -0700, Josh Steadmon wrote: > > > In a future commit, we will build the fuzzer executables as part of the > > default 'make all' target, which requires a C++ compiler. If we do not > > explicitly set CXX, it defaults to g++ on GitHub CI. However, this can > > lead to incorrect feature detection when CC=clang, since the > > 'detect-compiler' script only looks at CC. Fix the issue by always > > setting CXX to match CC in our CI config. > > Since you took my suggestion in patch 2, this "which requires a C++ > compiler" is no longer true, is it? And I don't think we'd even look at > the CXX variable at all, since it's now FUZZ_CXX. > > So this patch can just be dropped, I'd think. > > -Peff Done in V3.
