Hi, On Sun, 4 Nov 2007, Junio C Hamano wrote: > Shawn Bohrer <shawn.bohrer@xxxxxxxxx> writes: > > > +test_expect_success 'git-clean with prefix' ' > > + > > + mkdir -p build docs && > > + touch a.out src/part3.c docs/manual.txt obj.o build/lib.so && > > + cd src/ && > > + git-clean && > > + cd - && > > This is wrong for two reasons. > > - Is "cd -" portable? > > - What happens when git-clean fails? This test fails, and then > it goes on to the next test without cd'ing back. So it should be (cd src/ && git clean) && right? (Note that I also removed the dash, since it will be a builtin after the next commit.) Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html