On Sun, Nov 04, 2007 at 10:58:13PM +0000, Junio C Hamano wrote: > Two comments. > > * I have updated 1/10 with typo and indentation fixes. > > * I see you changed 2/10 to use OPTIONS_KEEPDASHDASH instead of > PARSEOPT_OPTS, but the scripts that do not want the --keep > behaviour do not set OPTIONS_KEEPDASHDASH to empty, so I do > not see how this updatet would make _any_ difference. The > user can still screw up by having OPTIONS_KEEPDASHDASH in > their environments by mistake, curiosity or just plain > stupidity. Hmmm right, I was worried by the fact that the old PARSEOPT_OPTS was being possibly diverted to inject malicious commands. I tend to find the forced `OPTIONS_KEEPDASHDASH=` thing quite painful, but indeed it is probably the sole way to guard ourselves against user stupidity (or more likely unclean environments). Do you mind adding: OPTIONS_KEEPDASHDASH= front to the 8 patches that needs it, or should I send an updated series ? (actually it's more like the 7 that needs it as git-clean has been rewritten as a builtin if I'm correct). -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpDdoWtxzrco.pgp
Description: PGP signature
