Karthik Nayak <karthik.188@gmail.
[snip]
>>> + /* for dangling symrefs we gracefully set the oid to zero */
>>> + if (!refs_resolve_ref_unsafe(&refs->base, update->new_ref,
>>> + RESOLVE_REF_READING, &update->new_oid, NULL)) {
>>> + update->new_oid = *null_oid();
>>> + }
>>
>> Can this actually happenn right now? I thought that the `read_ref()`
>> further up forbids this case.
>>
>> Patrick
>
> With update-ref, it won't happen anymore, because as you mentioned, we
> use `read_ref()`. I thought it was still worthwhile to have. But I guess
> its cleaner to remove this.
Well, just realized that this needs to stay because we also want the
resolved OID for the reflogs. Will modify the comment though.
Attachment:
signature.asc
Description: PGP signature
