"Linus Arver via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Linus Arver <linusa@xxxxxxxxxx>
> [...]
> + {
> + "with non-trailer lines in trailer block",
> + "subject: foo bar\n"
> + "\n"
> + /*
> + * Even though this trailer block has a non-trailer line
> + * in it, it's still a valid trailer block because it's
> + * at least 25% trailers and is Git-generated.
> + */
In the next reroll (sometime next week?), I should put the
... (see git_generated_prefixes[] in trailer.c).
comment up here (where we first mention "Git-generated" trailers)
instead of down in the last test case below.
> + "not a trailer line\n"
> + "not a trailer line\n"
> + "not a trailer line\n"
> + "Signed-off-by: x\n",
> + 1
> + },
> + {
> + "with non-trailer lines (one too many) in trailer block",
> + "subject: foo bar\n"
> + "\n"
> + /*
> + * This block has only 20% trailers, so it's below the
> + * 25% threshold.
> + */
> + "not a trailer line\n"
> + "not a trailer line\n"
> + "not a trailer line\n"
> + "not a trailer line\n"
> + "Signed-off-by: x\n",
> + 0
> + },
> + {
> + "with non-trailer lines (only 1) in trailer block, but no Git-generated trailers",
> + "subject: foo bar\n"
> + "\n"
> + /*
> + * This block has only 1 non-trailer out of 10 (IOW, 90%
> + * trailers) but is not considered a trailer because the
> + * 25% threshold only applies to cases where there was a
> + * Git-generated trailer (see git_generated_prefixes[]
> + * in trailer.c).
> + */
> + "Reviewed-by: x\n"
> + "Reviewed-by: x\n"
> + "Reviewed-by: x\n"
> + "Helped-by: x\n"
> + "Helped-by: x\n"
> + "Helped-by: x\n"
> + "Acked-by: x\n"
> + "Acked-by: x\n"
> + "Acked-by: x\n"
> + "not a trailer line\n",
> + 0
> + },
> + };
