Re: [PATCH 3/4] format-patch: new --resend option for adding "RESEND" to patch subjects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-04-17 08:43, Kristoffer Haugsbakk wrote:
On Wed, Apr 17, 2024, at 08:36, Dragan Simic wrote:
It also doesn't use imperative mood.

The sentence describes what the option does (usage). It doesn’t explain
what the commit message does. In context:

    Teach format-patch about --resend

    --resend adds "RESEND" to the subject prefix (producing "PATCH
    RESEND" by default).

Frankly, I don't like the "teach abc xyz" wording very much.  It isn't
some intelligent being to be taught something new. :)  That's just my
personal preference, of course.

Furthermore, starting a sentence with "--resend" isn't very good. Please
note that you're still using parenthesis, for which I already explained
why they should be avoided.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux