On Tue, Apr 16, 2024 at 11:33 PM Dragan Simic <dsimic@xxxxxxxxxxx> wrote: > This series fixes a bug that allows --rfc and -k options to be specified > together when running "git format-patch". This bug was introduced about > eight months ago, but it has remained undetected, presumably because of > lacking test coverage. While fixing this bug, also add a test that covers > this mutual exclusion, for future coverage. > > This series also adds --resend as the new option for "git format-patch" > that adds "RESEND" as a (sub)suffix to the patch subject prefix, which > eventually produces "[PATCH RESEND]" as the default patch subject prefix. > This subject prefix is commonly used on mailing lists to denote patches > resent after they had attracted no attention for a while. I'd recommend splitting this into two series, one which fixes the bug, and one which introduces the new feature. Otherwise, the bug fix is likely to be held hostage as reviewers bikeshed over the new feature and opine about whether such a feature is even desirable[*]. As a result, the bug fix may take much longer to get applied than if submitted as a standalone series. [*] For instance, my knee-jerk reaction is that we don't want to keep piling on these special-case flags each time someone wants their new favorite word as a lead-in to "PATCH". In addition to --rfc, and --resend, the next person might want --rfd or --tbd, etc. More palatable would be a general-purpose option which lets you specify the prefix which appears in front of "PATCH", but even that can be argued as unnecessary since we already have --subject-prefix.
