On Thu, 11 Apr 2024 at 10:20, 秃头灯笼鱼 via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: =?UTF-8?q?=E7=A7=83=E5=A4=B4=E7=81=AF=E7=AC=BC=E9=B1=BC?= > <ttdlyu@xxxxxxx> > > Signed-off-by: 秃头灯笼鱼 <ttdlyu@xxxxxxx> > - [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>] > + [--git-dir=<path>] [--work-tree=<path>] [--namespace=<path>] This makes it consistent with the instance later in the document, where it already says "--namespace=<path>". Ok. However, this is documented as "equivalent to setting the GIT_NAMESPACE environment variable". And gitnamespaces(7) says "GIT_NAMESPACE=<namespace>", so that is still inconsistent. I also see this: Note that namespaces which include a / will expand to a hierarchy of namespaces; for example, GIT_NAMESPACE=foo/bar will store refs under refs/namespaces/foo/refs/namespaces/bar/ So foo/bar isn't a file path. gitnamespaces(7) uses "path", "namespace" and "namespace path" sort of interchangeably. Even so, I think it could be a good idea to avoid "path" since it could give the wrong kind of ideas. I wonder if this patch should instead change both --namespace=<name> and --namespace=<path> to --namespace=<namespace> and give some motivation such as "Make the placeholder consistent with the gitnamespaces document." What do you think? Martin
