On Wed, Apr 10, 2024 at 10:21:48AM -0700, Junio C Hamano wrote: > Toon claes <toon@xxxxxxxxx> writes: > > >> [PATCH v2 03/12] ci: allow skipping sudo on dockerized jobs > > > > I think this title is somewhat misleading. While it's true, I don't > > think it's limited to dockerized jobs. Something more along the lines of > > "allow running install-dependencies.sh as root" would make more sense to > > me. > > It is true that dockerized is not the essential part of this change; > and it is that we skip sudo when we are already root. So I agree > with you that the original title is misleading. > > "allow running as root" is somehow a bit unsatisfactory, though. It > sounds as if _we_ were not allowing it before---what was preventing > us from doing so was a system without sudo. > > Stepping back a bit, I wonder if install-dependencies.sh will stay > to be the only one among ci/ scripts that need to run things as > root. If we moved the new logic in this patch to ci/lib.sh that is > included by everybody, then the title of the patch can become a > short and sweet > > ci: skip sudo when we are already root Agreed, this title reads much better than what I had. > > That's the only tiny remark I have on this patch series. > > Thanks. Thanks to both of you! Patrick
Attachment:
signature.asc
Description: PGP signature
