On Wed, Apr 10, 2024 at 12:28 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Dragan Simic <dsimic@xxxxxxxxxxx> writes: > > MIME-Version: 1.0 > > Content-Transfer-Encoding: 8bit > > > > Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y > > > > OK. Log says: > > Server: smtp.example.com > > This is obviously in the realm of subjective preference, but I find > that the prompt line is distinct enough among all other output that > we do not need an extra blank line to locate them. > > I'll let others comment as the "blank around prompt" smells quite > subjective and do not want to be the sole reviewer on it. For what it's worth, I had the same reaction about the extra blank line related to the prompt being unnecessary, but I didn't feel strongly enough to say anything about it, and I still don't feel strongly enough to suggest dropping this change.