On Wed, Mar 20, 2024 at 06:05:11PM -0400, Taylor Blau wrote: > The `max_bitmaps` parameter in `bitmap_writer_select_commits()` was > introduced back in 7cc8f97108 (pack-objects: implement bitmap writing, > 2013-12-21), making it original to the bitmap implementation in Git > itself. > > When that patch was merged via 0f9e62e084 (Merge branch > 'jk/pack-bitmap', 2014-02-27), its sole caller in builtin/pack-objects.c > passed a value of "-1" for `max_bitmaps`, indicating no limit. > > Since then, the only other caller (in midx.c, added via c528e17966 > (pack-bitmap: write multi-pack bitmaps, 2021-08-31)) also uses a value > of "-1" for `max_bitmaps`. > > Since no callers have needed a finite limit for the `max_bitmaps` > parameter in the nearly decade that has passed since 0f9e62e084, let's > remove the parameter and any dead pieces of code connected to it. Great, I'm happy to see dead code being cleaned up. And thanks (as always) for digging into the history to explain how we got here. -Peff
